Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Indeed, I should have tested my suggestion before asserting that it actually works.
Anyway, I've forked the translation and changed a few things.
Yeah, I wanted to avoid overflow, but that didn't work. Thanks for catching that.
I've tried your suggestion, but
b
ended up as0
or1
in most cases.I've also added assertion messages.
Can you explain the logic in the creation of
max
andmin
in the random test? To me, it seems like a particularly complicated way of writing1
and-1
, respectively.If the point is avoiding overflow, I'd simply generated a random
i32::MIN < x < i32::MAX
, a randoma <= x
) andb = x / a
.Also, this kata really needs good, clear assertion messages.
Fix
Rejected, because:
Added rust-specific info to the description.
Rejecting, because:
n<1 or not an integer
is a typical relic from authoring in a weakly/none typed language like Python or JS. It makes absolutely no sense in a strongly typed language, where input types can't be arbitrary, nor can they accidentally be negative integers whenu32
is chosen. Usingu32
and ignoring the input handling, which is completely tangential to the task anyway, was the correct choice here.No longer an issue.
Thank you for reviewing that.
There is no point in forking a translation just to update the original solution (which would end up published in the original author's name anyway). Especially when there are other things that actually need fixing, e.g. missing assertion messages.
Rejected.
Good catch. Fixed.
Approved
Also made a typo trying to type "typo".
Thanks for updating stale translations. I've approved a downstream fork.
For future reference: unless the reference solution is wrong/buggy or not performant enough, there's no reason to change it with your own in a fork; when the translation is approved, the solution (with your changes!) will show up under the original author's name, not yours. I'm sure you'll understand why it's undesirable to publish code in someone else's name.
Loading more items...