Draft

DateParse Function

Description
Loading description...
Mathematics
Fundamentals
Parsing
Date Time
  • Please sign in or sign up to leave a comment.
  • Blind4Basics Avatar

    Hi,

    • the specs are not matching the tests: 'S' should return None while it's supposed to be taken as 's'.
    • This has nothing to do with a date parser, this is a time converter.
    • why returning None when the value is negative? A negative timedelta makes sense.
    • The task as very little interest, and the DateParser class and its methods are totally useless => ?

    Cheers

  • hobovsky Avatar

    What is DateParser, and why is it preloaded? Users do not have to implement it, so why is it tested?

    • Lucifer_Frost Avatar

      in the description of Kata i sayd, you have class DateParser, and this class have list of function. You need create DateParse Function to optimize this class(

      in this Kata you need optimize class, but you also can make you own function without DateParser class function's.

    • hobovsky Avatar

      This does not make much sense. Either you need the DateParse class or not? My solution does not have the class, but still passes tests. Tests verify correcthess of the preloaded class, and not of my class. Why? What exactly is tested? My class is not tested, because I do not have it.

  • hobovsky Avatar
    • Code style issue: variable names should really be better than aaa, bbb, and ccc. Please assign some meaningful names to the variables. first and second are also not very fortunate names, maybe something like from/to or source/target would be better?
    • UX/test style issue: failed tests should use failure messages to present inputs which cased failure. You can see example kata or Python authoring guide for examples.
  • hobovsky Avatar

    Why is there Python code in Javascript translation? I think that Javascript was added by accident and needs to be removed.

  • hobovsky Avatar
    • What about the remarks posted on the previous version?
    • Seriously, aaa, bbb, ccc?

    Just to let you know, when a kata gets unpublished due to issues, you do not have to create a new one. You can fix it and publish it again.