Draft

The Real Minesweeper

3 of 6MikChan
Description
Loading description...
  • Please sign in or sign up to leave a comment.
  • geoffp Avatar

    This is a good kata, but too easy for 2kyu. I've rated it 4kyu.

    A suggestion: the Minesweeper class (in C++) should have a constructor that allows the positions of the mines to be specified, and this constructor should be used for at least one example test case. At present the only way to construct a Minesweeper object is to construct a random one. This makes TDD difficult because there's no way to conduct a reproducible test, or to create minimal working examples of bugs.

    • MikChan Avatar

      too easy for 2kyu. I've rated it 4kyu

      Yeah, a fair point.

      Actually, looking back with a fresh vision on what I've done here, I'm not very satisfied. I can spot some major issues, including the one you mentioned, (or for example that it is still possible to pass without solving by using somereinterpret_cast and looking into the source code, which is apparently possible on CW, I didn't know that back then), and also imho it doesn't follow the guidelines very well, and also not very translatable to other languages. So, shortly saying, ~yeah.

      Probably, I should remove it and recreate it from scratch. Or just remove it. Dunno.

    • Blind4Basics Avatar

      aside from the cosmetic, what's the actual difference with the 1 kyu? Are you really sure that's not a duplicate? (the actual question boils down to: does the user need to implement the same kind of logic than in the 1kyu? If so, yours would be a duplicate).

      Or is the key point: You can reset the game in case you failed?

    • MikChan Avatar

      Yeah, you're probably right too.

    • Blind4Basics Avatar

      errr... About what part? x)

      If that's about the "duplicate" one, maybe you should just unpublish it, then? (I know, it's painful, especially when you put a lot of efforts into the kata already... :s )

    • MikChan Avatar
      Suggestion marked resolved by MikChan 4 years ago