Draft
The Real Minesweeper
3 of 6MikChan
Loading description...
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
This is a good kata, but too easy for 2kyu. I've rated it 4kyu.
A suggestion: the
Minesweeper
class (in C++) should have a constructor that allows the positions of the mines to be specified, and this constructor should be used for at least one example test case. At present the only way to construct aMinesweeper
object is to construct a random one. This makes TDD difficult because there's no way to conduct a reproducible test, or to create minimal working examples of bugs.Yeah, a fair point.
Actually, looking back with a fresh vision on what I've done here, I'm not very satisfied. I can spot some major issues, including the one you mentioned, (or for example that it is still possible to pass without solving by using some
reinterpret_cast
and looking into the source code, which is apparently possible on CW, I didn't know that back then), and also imho it doesn't follow the guidelines very well, and also not very translatable to other languages. So, shortly saying, ~yeah.Probably, I should remove it and recreate it from scratch. Or just remove it. Dunno.
aside from the cosmetic, what's the actual difference with the 1 kyu? Are you really sure that's not a duplicate? (the actual question boils down to: does the user need to implement the same kind of logic than in the 1kyu? If so, yours would be a duplicate).
Or is the key point:
You can reset the game in case you failed
?Yeah, you're probably right too.
errr... About what part? x)
If that's about the "duplicate" one, maybe you should just unpublish it, then? (I know, it's painful, especially when you put a lot of efforts into the kata already... :s )