Retired
Traffic Lights Series - Part 2 (retired)
Loading description...
Fundamentals
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Well, the
TrafficLightController
is not behaving like a traffic light controller at all and at the current stage both the requirements and the tests are demanding too little, implementation that are straight out nonsense will still pass them.You should add more stuff to at least make
TrafficLightController
like an actual controller ;-)I think it might be worth adding more detail to the description about the number of traffic lights that can be controlled. I assume the intent is that the Traffic Light Controller can handle any number of traffic lights, however, in part 2 we're only interested in dealing with up to 2 traffic lights. In later parts the controller will need to deal with more lights.
I think it's up to the programmer whether they deal with only a max of 2 lights or any number of lights as long as the tests pass. However, knowing the above might make it easier to understand why you only mention two lights in the rest of your description.
p.s. looking forward to the next part!
If it is supposed to be a traffic light controller I would expect it to also be able to show "green" in at least SOME cases. Is the documentation still in progress of being written or is that case actually still missing?
Furthermore there is no behavior defined if a third traffic light gets added.
This comment has been hidden.