Retired
My First Kata - Greetings! (retired)
88 of 214ngmhprogramming
Loading description...
Fundamentals
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Not so good tests :)
Sample test should instantiate the class or the initial function should be made static.
for me, it gives an error: expected "Hey your own test case" but it was "Hey your own test case!" -- and I haven't added any "!" in my code
Nice job for your first kata. I would suggest more test cases to optimize the testing. I also would take a quick look at the kata details/instructions. They are worded with a bit of ambiguity in terms of where the exclamation should go. I had to look at the assertion in the sample test case to make sure what to submit.
make them use an if statement to greet females different then males
That's not an issue. That's a "suggestion".
Cannot get any simpler. Would be interesting to have to add not only "Hey" but a few other variations, like "Hi" or "Hello", randomly selected from a list, to make it a bit more interesting.
That's not an issue. That's a "suggestion".
Did I mark it as an issue? My bad, it was unintentional, because it is a suggestion.
Write your Katas just like you'd want to see them!
"My First Kata" in the title isn't really necessary, and neither is the apology at the start, as someone already pointed out.
Also, even though it's unlikely that someone would hardcode a simple Kata like this one, you should still add some random tests to prevent that. If you're just starting out, I'd be happy to help you out. :)
I've just removed the apology, but I'll wait for the original author to change the title to what he/she thinks is best.
Do not apologize is is your first kata! Also I do not know the name Toom, could we use Tom instead?
too easy for 8kyu tbh
Remember that
a + b
is an 8kyu problem.8kyu explicitly lists "hello, world" as an appropritate difficulty level. To me that clearly marks this kata as 8kyu as well.
The solution shall assert if the input is a string or not
Should go for the "learning to program" level.
Greetings Why do you request a name type Object in the function? Should it not be type string?
As noted by others, there is plenty of simple katas like this, I would suggest deleting this one.
C# Translation translation added! :)
Approved.
This comment has been hidden.
Props for creating!
Thanks!
Haskell translation added!
Approved.
Nice!
Sorry guys I was just trying out creating a kata lol
Furthermore, there are currently already a huge excess of such beginner level greeting-type Kata that literally take next to no effort to author so I would recommend unpublishing this Kata and coming up with a much better and original idea.
JavaScript version needs more test coverage; only 6 fixed assertions in the entire test suite is far from enough in terms of preventing logically flawed and/or hardcoded solutions. The most common way to increase code coverage is by the addition of 100+ random tests so please add these.
Crystal translation with random test cases you can basically copy and paste into your own Ruby translation (why don't you approve it yet your own work :D?), cheers :)
Imho but I think need more test cases in the kata
I'm pretty sure there are other katas like this, althogh I'm too lazy to look them up ;-)
Also, you may want to add more tests and even random tests, although it might not be necessary for such a simple kata.
Cheers
Similar Katas: