7 kyu
The Office IV - Find a Meeting Room
3,215 of 6,886PG1
Loading description...
Fundamentals
Arrays
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Having two diffrent return types isn't good practice. Returning
None
is fine.Took me some time to notice that this was letter 'O' in the array, not a zero 0 (: a little bit confusing, that part.
Clear!
No sample tests in crystal (reminder for me to add later ~~
fixed
C++ translation
Approved, thanks
Julia translation
Approved
One issue here -- the instructions specify "None available!" but you have to output "None available" (no exclamation point) to pass
Fixed.
Java translation here
Approved
This comment has been hidden.
Issue with your code, that's not the way to retrieve indexes
Haskell : https://www.codewars.com/kumite/5bfff3727172564f72000151?sel=5bfff3727172564f72000151
Approved
+1 for Mr Robot
PHP Translation Kumited - please accept :D
Approved
Ruby, Crystal, and CoffeeScript translations submitted for approval. Hope they're ok.
Approved
Crystal is missing example test cases, for some reasons expects
1
for empty rooms and in general might need a thorough review.And Pete should really learn to return only one type of result from his functions...
This series is funny. Feeling like working with Dilbert. Expecting more.
@petegarvin1
,I'm not sure if it's intentional but your description doesn't mention what to return if there isn't a "room" available? If you mentioned it in the description or added an example test case (or both), it would be a bit clearer.
I was using the Python version so I don't know if the JavaScript version has an example test case like that.
Thanks!
Added to example test cases and description - Javascript version.. will let the author do Python. Thanks for flagging :D
@petegarvin1
,Thanks for clarifying what the proper return value was supposed to be when no "room" was available!
an -> at
in the first sentence of the description"Your job at E-Corp"
Hopefully you don't mind the changes!
All good, thanks for the input :D
Python translation for approval.
Done :D
Will be cool to specify in the description how to handle the case where all the meeting rooms are busy, or to put an example test case.
Done
This comment has been hidden.
I guess something is broken here. In every case it doesn't work. I check for a ['O'], but it's always false.
Wrong random tests:
always undefined expected...
Unpublished. Will look into it
Should be fixed, I've changed the input
Works, thanks;-)!
Great, thank you! :)