6 kyu

Sales report

77ecolban
Description
Loading description...
Fundamentals
View
AllIssues2QuestionsSuggestions2Show Resolved
  • Please sign in or sign up to leave a comment.
  • ahmet_popaj Avatar

    Enjoyable programming kata indeed.

  • saudiGuy Avatar

    python new test framework is required. updated in this fork

  • saudiGuy Avatar

    This comment has been hidden.

  • siebenschlaefer Avatar

    The random tests call runTest(expected, actual) instead of runTest(actual, expected).

  • Blind4Basics Avatar

    This one was quite a pin in the ass to debug... because of the formating of the assertions. So I modified the tests to have a proper display of the actual and expected in the console.

    Other than that you have some queer things in this one that might make it a pin the ass for other reasons:

    • the order in the tuples is "inverted" compared to the string result. It seemed to me more logical to have them in the order (group, product, value) (of course, I made the error, forgetting the beginning of the description...)
    • "The type of the input is unknown other than that it is iterable"... Iterable is not subscriptable... (see my solution, you'll understand). Why don't you pass a list or a tuple directly to the user? That add nothing to the difficulty of the tasks, but I found that really annoying... :/
    • ecolban Avatar

      Thanks for your edits on the test code. Looks good.

      The reason for iterable and not being able to index is: Imagine you have a very, very large number of records. You might be reading them from a file that has been presorted. You cannot load all the records in memory and manipulate them as if they were a list. Yet, you should still be able to generate the report. So, even if your solution passes, it does not fulfil the intent of the kata. As to the order: Again, I was trying to mimic a real world scenario were the records have a particular format that is not necessarily taylored to a specific report. Finally, was hoping that more solutions would be using groupby, which does all the grunt work and serves the groups and the records in each group on a silver platter.

    • Blind4Basics Avatar

      Interesting point. I'll try to remember that. ;)

      Suggestion marked resolved by Blind4Basics 8 years ago
    • ecolban Avatar

      Yes. Look-ahead 1 and special case when you reach the end of input. This is what I mean by saying that groupby does the work for you.

  • zebulan Avatar

    @ecolban,

    I enjoyed this kata and made a couple of minor improvements to your kata as well.

    • I refactored the Basic Tests to make it easier to read.
    • I got rid of '''...'''[1:] by using a backslash to get rid of that first newline character in your multi-line strings
    • I changed all of the xrange's to range so now the kata works for both Python 2 & Python 3

    Hopefully you don't mind the changes!