7 kyu
Sir , showMe yourID
657 of 1,339gomesalexandre
Loading description...
Regular Expressions
Strings
Fundamentals
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Description is too vague. You don't really know what you're trying to solve until you click attempt and can view the test cases
( JS, possibly others )
The Example tests seem to warn for names with accented vowels in them. This then doesn't happen in Submit tests.
Either remove accented letters from the kata completely, or test consistently between example and submit tests ( ie, add fixed and random tests expecting both
trueandfalsefor names with accented vowels ).Description promises us a "String" that is specified to be a first name, either hyphenated or not. So
return trueshould solve the kata.That is, supposing
yourIDis that string, in which case it is horribly misnamed.I don't suppose things work that way, but it is unclear how things are supposed to work.
The grammar is terrible yes, but the meaning is clear enough. There are literally specs at the bottom.
The meaning may be clear enough to you, it really is not to me.
The description is not accurate in defining correct names, and in defining the input.
A name is a uppercase letter followed by one or more lowercase letters. The input is not necessarily composed of valid names ( this is the whole point of the kata ).
String,word,name,inputandyourIDare sprawling all over. Specifications should be correct, complete, and consistent; what names you call things matters.Many issues in JavaScript:
Fixed. Holy were those random tests bad.
Fixed in CS as well
python new test framework is required. updated in this fork
Approved
"Your mission if you accept it,..." funny
Ruby 3.0 should be enabled.
Enabled in this fork
Missing fixed tests such as
A--------in JS and CS as well as lack of random tests coverage which make such solution passed easily !!!Fixed. That solution no longer passes.
Why is the name "Jean-luc" supposed to return False? Is it because "luc" is not capitalized? This was not clear in the kata description.
My solution passed all tests, but i can`t submit it. When I try to do it an issue appears: "There was an issue submitting your final solution". Why?
It's not an issue of this kata. Since days it's a codewars problem, had it many times on different katas. But look into your list, perhaps you have the points and it's listed as solved. It's always if you submit a solution more than once or if you submit a new solution for the same kata... A problem is that the kata stays locked...
Yes, it is listed as solved. Thank you!
There was an issue submitting your final solution codewars
Marked as resoled, CW's servers are quite slow these days
Marked as resoled, CW's servers are quite slow these days
This comment has been hidden.
Try to use a simpler regex, and testing for the string to be true first.. ;)
This comment has been hidden.
ok I just solved it.. by accident.
Can any kind soul tell me about matching hypen only?
Refer to the top-voted solutions.
Great kata!
Thanks man :D
CoffeeScript Translation Kumited! Please Accept :D
Nice!
TY!
More test cases, so name can't start or end with
-, and maybe can't have upper-case letters anywhere but first letter of new word.Good ideas; done in Ruby and Python.
Nice idea, added !
Could you mark the issue as resolved now ?
You can close it on your own, Alex.
Done.
Translations submitted; note: no special characters as they are not well supported in Python or Ruby (to put it into few words).
Will do that for js version too ;)
But can you see the translations now, right?
This comment has been hidden.
I agree with @zebulan, there should be more edge test cases (I'm talking about python). I would add a few more to his list:
Also, it's not clear if a name can be one letter only? Is "Z" a valid name or not?
Good ideas: tests updated in both Ruby and Python.
Need a couple with hypens at beginning and end:
Done!
Hey, nice kata, a few things to fix:
Random tests added ;)
You could possibly list all the possible accentuated characters that may appear in the tests in your Kata description.
Basically any vowel with an accent :D how would you put it?
Put them into the description: people outside a Latin language can have serious troubles having to write on their own something like "àèéìòù", plus your language has even more accented vowels to be expected.
This comment has been hidden.
It's a WIP !
WOOPS. My bad. For a strange reason complete solution had gone into initial solution. Now that's bad ;) fixed, of course