6 kyu
Regexp Basics - is it IPv4 address?
224 of 2,746taw
Loading description...
Regular Expressions
Fundamentals
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
python new test framework is required. updated in this fork
Approved
assertTrue&&assertFalseshould be used for fixed test of PHPJS: Node v14 should be used along with its appropiate assertion tools (Mocha + Chai). Refer to this and this
Updated to Node v14
I think regex should be enforced.
It seems this kata is a duplicate of this one. I copied/pasted my solution from it and it worked with only changing the name of the function and variable.
Yes, but this one emphasizes on the use of regex. Although I'd say that the author should've enforced it.
How? In the title only... Does a different title make a kata different?
https://www.codewars.com/kumite/660a8ff61bcdf3002c3efd00?sel=660a8ff61bcdf3002c3efd00 just 3 years late, but made this fork, tho if it should be a new kata it can be done easily.
This comment has been hidden.
There's a lot of errors with this approach. To begin with, it's not a regex :P But if you read the actual error, its cause is the fact your're trying to compare a string (ele) with an integer, which has incorrect value too. Also, your loop will return after checking just the first octet, which isn't what you want.
This kata made me realise a subtle difference in 2 related components of regular expressions so thank you for that. May I suggest though that for Ruby you make outputs - beyond the first output that fails - visible, I would've solved the kata in a fraction of the time had that been the case. I was basically having to guess what the problem was.
Having a problem with the '127.0.0.1\n' test. I removed the '\n' and it still has an error. All other tests passed
You should not remove it, as the expected result is
False, but your code checks the IP address with trailing\nremoved which results inTrueIs this question best with regex? Found the tests to contain different characters you have to account for. It's always the edge cases we have code wars with!
This comment has been hidden.
For string that could be in multiple lines you need
\A/\Zinstead to match the entire string:https://stackoverflow.com/questions/4250062/what-is-the-difference-between-and-a-and-z-in-regex
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
My regex-fu is weak! I had to elif my way out of the box and bookmark it for further study and practice. Any suggestions on regex sources other than the python.org documentation? They apparently ain't working for me.
Good kata, by the way.
This comment has been hidden.
This comment has been hidden.
Thank you so much for the great regex kata!!! Regex will add a lot of power and efficiency!!!
What is the 83th test case?
It's a random testcase, but you can print the input to the console to see what it is.
Thank you for giving the idea! Am I missing something? It seems that 127.0.0.1 is being checked for two times. For the first case it is expected that it will return true, but for the second time - false.
Here is the output:
1) Log 127.0.0.1 ✔ Test Passed: Value == true
2) Log 127.0.0.1 ✘ Expected: false, instead got: true
There is probably a whitespace character at the beginning or the end of the input. You can return the input as an array so that you can see each individual character.
E.g. ['1', '2', '7', '.', '0', '.', '0', '.', '1']
Your code must return false if there is a whitespace character in the input.
Yeah.. I should have thought of it. I've completed the task. Thanks much for you help!
PHP translation Kumited! Please check and approve)
The website is totally crap and just tells me "Multiple kata translations have been published" without any links or titles or anything.
It looks like my translation approved) Thanks.
CoffeeScript Translation Kumited! Please Accept :D
'alr approved some time ago'
What's wrong with my solution? It always time out and don¿t even gets salved :(
This comment has been hidden.
Your solution fails when n = "230.[...]" and anything ending in a zero. It fails when the first digit is 2 and the third digit is [06789].
You need to split your code into two sections. Those 200 <= n <= 249 and those 250 <= n <= 255. So that only the last digit is tested for [0-5] {when 250 <= n <= 255} and the last digit is tested for [0-9] {when 200 <= n <= 249}.
Also why are you listing all the numbers - [123456789] can be shorted to [1-9].
Sorry it's really difficult to give a thorough explanation when it comes to regex
Thank you so much I realized that there was a runner failure and reported, Thank you for the feedback :)
You have a test to assert '127.0.0.1' to true and other to false, in Ruby...
What is the problem? Tests are all fine.
If you say that the same result having to be both true and false at the same time is fine, then it is fine...
You're misreading the test, notice how a lot of people managed to pass just fine.
But it is the exact same input, and two different results. I must missing something, but I can see what.
Try
.inspectmaybe?I feel stupid now. You are right, I'm sorry.
No problem ;-)
All basic test passed, but in "Random Test" it gives: name 'xrange' is not defined. But I'm not using 'xrange', it seems the test is write with Python 2, but I'm using Python 3, right?
Yeah, codewars used Python 2 last time I checked. Did they switch to Python 3?
There are both 2 and 3. If the code of a kata fails to run in the different version from the one it was created for then it shouldn't be possible to choose that version for solutions:
Codewars now supports both Python 2 & 3. If the tests can run in both versions (automatically when you Publish a Python kata), then both versions of Python are available (in a dropdown menu above the editor) for the user to choose from.
The random tests in this kata do use
xrangeso they will not work for Python 3. When I just went and clickedTrain Again, only Python 2 is available to use (because the tests aren't compatible). I'm not exactly sure why@divergeris having this issue but I have seen it before when forking a Python 2 kata, the kumite section seems to default to the Python 3 interpreter causing the same issue. Since the tests aren't Python 3 compatible, the option to use Python 3 shouldn't be available (maybe a bug?).@taw, You can make this kata compatible with both versions of Python by changingxrangetorangein this line:for _ in xrange(4):. If you look at new Python translations by@GiacomoSorbi, he usesrangenow to solve this issue. It wasn't a mistake on his part, Codewars just didn't support Python 3 when his tests were originally written.Fixed now. They didn't have Python 3 at all back then.
in JavaScript how can I get the string with IP?
I think I'm having trouble with the test cases
Thanks a lot for this Kata, I'm fairly new to Regex and this has taught me how to shorten and simplify regexes as well as allowing repeats :D
This comment has been hidden.
Test added.
nice :) I really like this series.
This comment has been hidden.
238 added to test suite.
Most of the solutions would fail for 127.0.0.1. Trailing . is not a valid IP format. I would throw in a test case for that.
Tests addd in all languages.
Awesome! Thanks for your contributions!
I also think it is a duplicate of IP validation.
But maybe it could be a different Kata if you make the use o Regex mandatory.
In JavaScript you can
.toStringthe function and check the code. InC#you can do that with reflection, in other languages there might be some ways to do that.Well, sort of:
So I'm not terribly tempted to try merging it, mostly because of points #2 and #3 above.
There is. Solutions may be Regexps or just strings rather than methods and then they are converted to strings and recompiled before testing.
Nice kata, differs from other that dont accept leading zeros.
Wow, you certainly were fast in approving my translations :D
If I might add something, really nice testing suite you got under the hood for a beginner level kata :)