Beta

Spanish class help

54 of 139kylebuttner
Description
Loading description...
Fundamentals
View
AllIssues4QuestionsSuggestions1Show Resolved
  • Please sign in or sign up to leave a comment.
  • benjaminzwhite Avatar

    Cool little kata; author is inactive and Python tests need to be updated to new layout.

    Also missing some useful tags, like strings for example, in description.

  • Chrono79 Avatar

    Needs a javascript tests update (also random tests as written below), it throws warnings

    assertSimilar is deprecated, use assertDeepEquals
    
  • Blind4Basics Avatar

    specifications are incomplete:

    • can we find empty strings in the tests? -> no
    • an example with a string of length 1 shoul dbe given in the description too
    • especially, it should be told that the default gender is "masculine" for the single letter "s"
  • donaldsebleung Avatar

    Javascript version of Kata needs random test cases

  • UrNotSorry Avatar

    Is there a bug with the test cases? For the random tests, I see outputs like this: wrong result for el w, los punis, la za, las jrmkxas, el d, el umiol - Expected: ["el el w", "los los punis", "la la za", "las las jrmkxas", "el el d", "el el umiol"], instead got: ["el w", "los punis", "la za", "las jrmkxas", "el d", "el umiol"] The expected values don't seem to make sense.

  • CrazyMerlyn Avatar

    Some examples with more than one argument would be great. Both description and example tests have only one argument. And mention what to do when the letters are uppercase. Or mention that words will always be lowercase.

    Adding more tests, preferably randomized, would be nice too.

    Also, you can equate arrays with Test.assertSimilar instead of using Test.assertEquals on every element. For other tips on making a better Test Suite, see Tests Best Practices

    • kylebuttner Avatar

      Thanks for this. Have switched to Test.assertSimilar for the testing, included a bit more description/examples, and added some more sample tests. Working on doing randomized tests. Appreciate the direction -- really helpful!