Beta
Spanish class help
54 of 139kylebuttner
Loading description...
Fundamentals
View
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Cool little kata; author is inactive and Python tests need to be updated to new layout.
Also missing some useful tags, like strings for example, in description.
Needs a javascript tests update (also random tests as written below), it throws warnings
specifications are incomplete:
"s"
All single letters in spanish are feminine.
Javascript version of Kata needs random test cases
Is there a bug with the test cases? For the random tests, I see outputs like this:
wrong result for el w, los punis, la za, las jrmkxas, el d, el umiol - Expected: ["el el w", "los los punis", "la la za", "las las jrmkxas", "el el d", "el el umiol"], instead got: ["el w", "los punis", "la za", "las jrmkxas", "el d", "el umiol"]
The expected values don't seem to make sense.not an issue
Some examples with more than one argument would be great. Both description and example tests have only one argument. And mention what to do when the letters are uppercase. Or mention that words will always be lowercase.
Adding more tests, preferably randomized, would be nice too.
Also, you can equate arrays with
Test.assertSimilar
instead of usingTest.assertEquals
on every element. For other tips on making a better Test Suite, see Tests Best PracticesThanks for this. Have switched to Test.assertSimilar for the testing, included a bit more description/examples, and added some more sample tests. Working on doing randomized tests. Appreciate the direction -- really helpful!