Draft
Time For Validation
29 of 55patrickwalkowicz
Loading description...
Regular Expressions
Algorithms
Date Time
This comment has been reported as {{ abuseKindText }}.
Show
This comment has been hidden. You can view it now .
This comment can not be viewed.
- |
- Reply
- Edit
- View Solution
- Expand 1 Reply Expand {{ comments?.length }} replies
- Collapse
- Spoiler
- Remove
- Remove comment & replies
- Report
{{ fetchSolutionsError }}
-
-
Your rendered github-flavored markdown will appear here.
-
Label this discussion...
-
No Label
Keep the comment unlabeled if none of the below applies.
-
Issue
Use the issue label when reporting problems with the kata.
Be sure to explain the problem clearly and include the steps to reproduce. -
Suggestion
Use the suggestion label if you have feedback on how this kata can be improved.
-
Question
Use the question label if you have questions and/or need help solving the kata.
Don't forget to mention the language you're using, and mark as having spoiler if you include your solution.
-
No Label
- Cancel
Commenting is not allowed on this discussion
You cannot view this solution
There is no solution to show
Please sign in or sign up to leave a comment.
Specs are nuts. Unpublishing.
Python:
random tests always expect False.
Duplicate to existing katas (just search for time conversion? ;-))
Great kata! Personally one of my favourite katas on this website and one of the best designed and made :).
It seems that some of the random tests provide invalid times but do not expect false.
Testing for convert_time(12, 21:44AM)It should work for random inputs too - Expected: "09:44AM", instead got: falseI agree. The random tests in the Ruby version of this Kata, generate several different invalid times as input but don't expect "false" to be returned. Examples include: 23:24AM, 20:49AM, 22:08AM, ...
Translated into Python too, thanks for the Ruby approval :)
Thanks for your contribution :)