Kata

Thank you boss for helping out this code newbie, that was exactly my problem, easy fix.

So people don't accidentally count 0 as an odd digit and fail to understand why their solution isn't working?

0 is an even number, hence the question.

"Among the general public, the parity of zero can be a source of confusion."

So once again I submit, "so people don't accidentally count 0 as an odd digit and fail to understand why their solution isn't working?"

Don't count zero as an odd digit.

Written like that, you can either think it is an even number or that it is an odd number but you shouldn't count it, which is wrong. Either say it is an even number or mention the odd digits if you need clarification.

Thanks for presenting a valid solution to the issue

Thanks for the reply. I honestly don't remember ever hearing of people thinking 0 would be an odd number. I suppose there could be a question around it for people new to math and coding. But yeah, if it needs to be clarified, they might as well go ahead and list all the odd digits.

No worries. I mean, it's not wrong... 0 of course shouldn't be counted as an odd digit. Just a bit humorous.

I removed it. This precision doesn't make sense, if we suppose people might not know what even digit is, we should give the whole list of them, but it seems too much (if someone doesn't have clear what an even number is, he can just check it).

Do you know what odd numbers are, don't you? The dashes separate them:

454793
   79
    93
4547-9-3    

7 and 9 and 9 and 3 are the only pairs of odd numbers next to each other there.

You do know how to answer a question without being a dick, don't you?

Chill bro, no need to be harsh.

Positive isn't mean non-negative.

Oh wow, can't believe I missed that. Usually run it on both solution and setup before publishing.

I can't edit it now it's been approved :(

FYI - typo in Java initial solution return "":

Fixed, thanks; if you have the old version, just paste as sample tests:

Test.assert_equals(insert_dash(454793),'4547-9-3')
Test.assert_equals(insert_dash(123456),'123456')
Test.assert_equals(insert_dash(1003567),'1003-567')
Test.assert_equals(insert_dash(24680),'24680')
Test.assert_equals(insert_dash(13579),'1-3-5-7-9')